TST: harmonize testing namespace in TestCase (GH8023) #8923
Conversation
| if np.array_equal(np_array, assert_equal): | ||
| return | ||
| raise AssertionError('{0} is not equal to {1}.'.format(np_array, assert_equal)) | ||
| def assert_numpy_array_equal(self, *args, **kwargs): |
There was a problem hiding this comment.
I think you can just pass the np_array and assert_equal arguments, as this will mask wrong arguments
There was a problem hiding this comment.
@jorisvandenbossche ok will do, i thought this would be better because when 1 function changes then the other will have to be updated.
|
@papaloizouc Are you interested in trying to add the other |
|
@jorisvandenbossche sure will do |
|
I think we should try to do the adding of the methods a bit more automatically (so also the docstring are kept as the original). Eg something like |
|
sure easy enough to inspect the module namespace and auto add the methods to TestCase via a generated wrapper |
| setattr(_TestCase, name, staticmethod(obj)) | ||
|
|
||
| patch_test_functions() | ||
| TestCase = _TestCase |
There was a problem hiding this comment.
you don't even need to do this in a function, just put it at the end of the module and directly update TestCase. (pls put a comment before though explaining what this is doing).
jreback
changed the title
dxe4
force-pushed
the
refactor_tests_8023
branch
3 times, most recently
from
335df10 to
12d75f3
Compare
TST: changed *args, **kwargs to fixed arguments. pandas-dev#8023 TST: Moved rest of the test functions to module level. pandas-dev#8023 TST: patch all module level assert functions to TestCase. pandas-dev#8023 CLN: Cleanup TestCase assert functions pathing pandas-dev#8023
dxe4
force-pushed
the
refactor_tests_8023
branch
from
12d75f3 to
844f7ae
Compare
|
Merged via ace3c46 |
|
@papaloizouc Thanks! |
closes #8023
Merged via ace3c46